Comments on Hive Development Limited: Google Web Toolkit (GWT) MVP Example

Hi, First thanks for this excellent tutorial! Thi...

2010-07-24T14:22:44.083+01:00

Hi,

First thanks for this excellent tutorial! This incredibly helps to jump start.

It looks like the code is no longer compatible with the 2.04 GWT environment as I get the following ERROR which breaks the app.

Using SDK 2.0.4, Eclips (latest) and Java 1.6 on OSX

It starts with a warning:
14:56:04.924 [WARN] [greetmvp] Line 41: Referencing deprecated class 'com.google.gwt.user.client.rpc.SerializableException'

[INFO] Calling doSend
[ERROR] Handle Failure:

14:56:30.248 [ERROR] [greetmvp] 2010-07-24 14:56:30,247 [ERROR] Handle Failure:
com.google.gwt.user.client.rpc.IncompatibleRemoteServiceException: Type 'co.uk.hivedevelopment.greet.shared.rpc.SendGreeting' was not assignable to 'com.google.gwt.user.client.rpc.IsSerializable' and did not have a custom field serializer. For security purposes, this type will not be deserialized.

Now to fix this weired error, remove the gwt-sevelet.jar from the WEB-INF/lib dir and things will work again.

Wessel

Hello Thanks for a great guide. I have a problem...

2010-06-18T13:59:10.894+01:00

Hello

Thanks for a great guide.

I have a problem with the changing of presenters/views.

I have a LoginPresenter/LoginView when i login i want to change the presenter/view to StartPresenter/StartView.

Where and how should i do this?

Thanks again

/Filip

@Chris: Yeah, that's clear. I wanted to know, wher...

2010-05-27T10:16:58.581+01:00

@Chris: Yeah, that's clear. I wanted to know, where the GreetingResponsePresenter will be triggerd. But I believe, that I have found the point: It's because of the

bindPresenter(GreetingResponsePresenter.class, GreetingResponsePresenter.Display.class, GreetingResponseView.class);

in GreetingClientModule, right?

Thanks for your answer.

@seakey Nothing too clever I'm afraid. GreetingR...

2010-05-26T23:31:14.047+01:00

@seakey

Nothing too clever I'm afraid. GreetingResponsePresenter defines this:

@Override
protected void onBind() {
...

eventBus.addHandler(GreetingSentEvent.TYPE, new GreetingSentEventHandler() {

@Override
public void onGreetingSent(final GreetingSentEvent event) {
...
display.getDialogBox().show();
}
});
}

Obviously it's the call to .show() that causes the display of the dialog box. The code block is a handler for a GreetingSentEvent which is fired when a server call returns successfully:

public class GreetingPresenter extends WidgetPresenter {
...

private void doSend() {
...
dispatcher.execute(new SendGreeting(display.getName().getValue()), new DisplayCallback(display) {

...
@Override
protected void handleSuccess(final SendGreetingResult result) {
// take the result from the server and notify client interested components
eventBus.fireEvent(new GreetingSentEvent(result.getName(), result.getMessage()));

}

});
}

Blogger has scrubbed generics from the code snippe...

2010-05-26T23:21:16.483+01:00

Blogger has scrubbed generics from the code snippet I just posted. :(

@greg I've done code splitting with gwt-presenter...

2010-05-26T23:19:05.212+01:00

@greg

I've done code splitting with gwt-presenter. It's a bit much to write about here in the comments, but I was able specify a module:

public class Module extends AsyncModule\
{

@Inject
public Module(final Provider value)
{
super(value);
}

}

Where UserWindowPresenter is a presenter that has a few sub presenters relating to a particular business area.

Elsewhere, I then show the above presenter by having something like:

public class PresenterRegistry
{

private Provider userWindowPresenterProvider;

@Inject
public void setUserManagementPresenter(final Provider provider)
{
userWindowPresenterProvider = provider;
}

private void revealUserManagementWindow()
{
GWT.runAsync(new RunAsyncCallback()
{
@Override
public void onFailure(final Throwable reason)
{
}

@Override
public void onSuccess()
{
final Presenter presenter = userWindowPresenterProvider.get();

presenter.revealDisplay();
}
});
}

}

I then call into the presenter registry to show a form.

I hope that helps. I'd like to find some time to write this up properly on the blog in the very near future, so watch this space.

Hi, I have a question concerning the DialogBox. H...

2010-05-26T22:17:35.821+01:00

Hi,

I have a question concerning the DialogBox. How the DialogBox know, that it should appear? In other words: Which event triggers the appearance of this DialogBox?

In GreetingPresenter, you fire a GreetingSentEvent. And in GreetingResponsePresenter you add a handler for the GreetingSentEvent to the eventBus.
But what are the steps in between? From where will be the GreetingResponsePresenter called?

hi, is there any way of achieving some way of cod...

2010-05-26T00:25:58.815+01:00

hi,

is there any way of achieving some way of code splitting here? The problem i see is in the fact that all view/presenters bindings take place in GreetingClientModule class. This will inevitable have a significant impact on the startup/download time of even medium size application. Is there any way of incorporating something like http://code.google.com/webtoolkit/articles/mvp-architecture-2.html#code_splitting

GWT.runAsync(new RunAsyncCallback() {
...
public void onSuccess() {
...
}
}

by the way, very good article.

Good tutorial but this: @Override 30. protected vo...

2010-04-20T15:51:52.537+01:00

Good tutorial but this:
@Override
30. protected void dispatch(final GreetingSentEventHandler handler) {
31. handler.onGreetingSent(this);
32. }

will not work since Overiding this method requires EventHandler rather than GreetingSentEventHandler

Greetings from http://AngloPolish.com

Thank you very much for this tutorial but i want t...

2010-04-06T12:40:01.345+01:00

Thank you very much for this tutorial but i want to know why have you put the instantiation of "GreetingResponsePresenter" in the constructor of GreetingPresenter and not in the constructor of AppPresenter?

@Hang - not sure about that error, I'd have to see...

2010-04-02T10:47:49.993+01:00

@Hang - not sure about that error, I'd have to see some code. Have you downloaded the ready-to-go eclipse project of this example?

http://static1.hivedevelopment.co.uk/blog/gwt-best-practise-mvp-di-command/GreetMvp.zip

Cheers,

Chris

Hi I habe been getting the following errors while...

2010-04-02T10:27:44.839+01:00

Hi

I habe been getting the following errors while compiling the client code. Can anyone help?

Compiling module co.uk.hivedevelopment.greet.GreetMvp
[ERROR] Errors in 'generated://D4E46AF2E7AE7489E374F22EA6E3A89C/co/uk/hivedevelopment/greet/client/gin/GreetingGinjectorImpl.java'
[ERROR] Line 19: Rebind result 'co.uk.hivedevelopment.greet.client.mvp.GreetingPresenter.Display' must be a class
[ERROR] Line 34: Rebind result 'co.uk.hivedevelopment.greet.client.mvp.GreetingResponsePresenter.Display' must be a class
[ERROR] Line 91: Rebind result 'com.google.gwt.user.client.ui.HasWidgets' must be a class
[ERROR] Line 144: Rebind result 'net.customware.gwt.presenter.client.EventBus' must be a class
[ERROR] Line 159: Rebind result 'net.customware.gwt.dispatch.client.DispatchAsync' must be a class
[ERROR] Cannot proceed due to previous errors

oops. forgot the link. This is a similar sample pr...

2010-02-19T23:14:33.279Z

oops. forgot the link. This is a similar sample project as the one described above:

http://code.google.com/p/gwt-mvp-sample/

It looks like MVP is a good idea in theory, but it...

2010-02-19T23:13:32.595Z

It looks like MVP is a good idea in theory, but it clearly turns simple tasks into monolithic implementations. Look this sample MVP project here. A simple CRUD operation on a "task" becomes 16 classes. I'm sold on the idea. Not sold on the pain it takes to make this happen.

Hi. Just wanted to thank you guys for this walkth...

2010-01-24T18:07:24.796Z

Hi.

Just wanted to thank you guys for this walkthrough. I have been using it extensively while planning my own project which I describe on http://borglin.net/gwt-project

Chris, Thanks for the code, I got it to work with...

2010-01-22T14:07:09.572Z

Chris,

Thanks for the code, I got it to work with some minor modifications (see below).

1) Used JDK 6
2) Removed @override annotations as per Eclipse's recommendation in a few places.
3) Removed the classic RPC classes such as GreetingService.java, GreetingServiceAsync.java, GreetingServiceImple.java and SendGreetingHandler.java (under sitealright package).

Curious, have you tried to implement this using SmartGWT yet, we might see more use of this then.

Hi all, I've applied gwt-presenter with a server ...

2010-01-22T08:55:57.054Z

Hi all,
I've applied gwt-presenter with a server side spring support for spring-security at method level.

Code can be found at http://code.google.com/p/orcades-gwt-spring/

Please comment.
The documentation is short, but fluent maven user should make it.

// NOTE: the servlet context will probably need ch...

2009-12-23T03:00:42.135Z

// NOTE: the servlet context will probably need changing
serve("/greetmvp/dispatch").with(DispatchServiceServlet.class);

I don't really understand these code lines.
Where can I configure that the RPC commands sent from the client is sent to "/greetmvp/dispatch"?

Should that be configured in the web.xml file?

@killallhumans - neat!

2009-12-02T12:38:06.790Z

@killallhumans - neat!

@bot - sorry for late reply. > So this event bus ...

2009-12-02T12:36:57.579Z

@bot - sorry for late reply.

> So this event bus is used only on the client gwt side to transfer event messages to the "subscribed" views?

Yes.

> For example if i have some custom slider and i want to update several other ui components on my screen when the slider moves this is the perfect solution? And in that way the ui components wouldn't know about the slider.

Yes exactly.

> Also could you place another link for this "hupa" project because the above is broken.

This project was moved a short while ago to here:

http://james.apache.org/hupa/index.html

>And my last question for now:
>Is this sample hello world project configuration and setup ready for real project usage? I asj because i do not know any thing about gin, juice, gwt-dispatch and gwt-presenter, and i am going to implement some small project with gwt in the next month and i would like to try this architecture, but i am afraid that i will not have much time to investigate in the above libraries.

I used it for my project and can recommend the MVP architecture. As various comments above point out, there are some old artifacts lying around the project which can be deleted. Please be advised that the gwt-presenter project is undergoing a bit of an overhaul at the minute so my code might need adjusting if you upgrade the libraries. That said - you should still be able to get a lot done with the version supplied with the project.

All the best,

Chris.

I have created a skeleton app, for anybody who wan...

2009-11-29T15:47:27.867Z

I have created a skeleton app, for anybody who want's to save few minutes. It uses all the above stuff, but instead of Javish serialized RPC, it uses Restlet GWT library, and jruby + Sinatra backend.

http://github.com/skrat/sinwar

Hi, great tutorial. So this event bus is used only...

2009-11-22T13:39:31.911Z

Hi, great tutorial.
So this event bus is used only on the client gwt side to transfer event messages to the "subscribed" views?
For example if i have some custom slider and i want to update several other ui components on my screen when the slider moves this is the perfect solution? And in that way the ui components wouldn't know about the slider.

Also could you place another link for this "hupa" project because the above is broken.

And my last question for now:
Is this sample hello world project configuration and setup ready for real project usage? I asj because i do not know any thing about gin, juice, gwt-dispatch and gwt-presenter, and i am going to implement some small project with gwt in the next month and i would like to try this architecture, but i am afraid that i will not have much time to investigate in the above libraries.

Regards and again great work.

Thanks for this code - it helped me understand. I ...

2009-11-20T11:37:39.891Z

Thanks for this code - it helped me understand. I think it would of been better if some of the unnecessary code was removed such as GreetingView.java's RootPanel.get("foo").add(name) and the GreetingService.java file.

I had some problems running the linked project in ...

2009-11-13T18:43:23.975Z

I had some problems running the linked project in OSX 10.5.7.

I turns out that GWT hosted mode requires JDK 1.5 here. The problem was that gin.jar (the only lib actually compiled from source by the article authtor) was compiled with JDK 1.6.

I thought I should mention this for others on this OS.

Bummer... I don't think this will work on OS X 10....

2009-11-13T07:02:12.257Z

Bummer... I don't think this will work on OS X 10.5 with JVM 1.5 or JVM 1.6 (-d32). At least, I couldn't get it to work.

Challenges faced:
Project doesn't support JVM 1.5, so I tried JVM 1.6... and on 10.5, I don't think JVM 1.6 supports a 32 bit mode.

Anyone else successful?